Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add whatsnew entry for v0.23 #2346

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

greglucas
Copy link
Contributor

This is in preparation for the v0.23 release. Let me know if I missed any features and if we should add anything else to this list.

@rcomer
Copy link
Member

rcomer commented Mar 9, 2024

#2280 expired some deprecations. Should that be noted in the deprecations section?

Maybe a note that we now officially support python 3.12?

Something about the whereabouts of the feature download script might be useful for those who need to use it (#2263).

Over in Iris, we have started including a reviewer credit for the more substantial changes (e.g. v3.8 features). What do you think about doing that here? I definitely think you deserve some credit for the GridLiner and FeatureArtist changes!

@greglucas
Copy link
Contributor Author

#2280 expired some deprecations. Should that be noted in the deprecations section?

Maybe a note that we now officially support python 3.12?

Something about the whereabouts of the feature download script might be useful for those who need to use it (#2263).

Thanks! I added all of these.

Over in Iris, we have started including a reviewer credit for the more substantial changes (e.g. v3.8 features). What do you think about doing that here? I definitely think you deserve some credit for the GridLiner and FeatureArtist changes!

That is nice, I think that'd be a great idea. It'd also be good if we start building this file as we go rather than having someone go through old commits and PRs to see what was changed :) I just asked questions during the review, you found the answers! Much less work for me, so I appreciate all the effort you put into updating those features.

Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd also be good if we start building this file as we go rather than having someone go through old commits and PRs to see what was changed :)

Yeah it's usually easier to describe something when you only just did it too!

docs/source/whatsnew/v0.23.rst Outdated Show resolved Hide resolved
docs/source/whatsnew/v0.23.rst Outdated Show resolved Hide resolved
@rcomer
Copy link
Member

rcomer commented Mar 17, 2024

I think this is good to go if no-one else has comments. @greglucas do you want to squash the commits? Feel free to self-merge either way.

@greglucas
Copy link
Contributor Author

I have set the release date for tomorrow April 4th in this change note now. That might be optimistic, but I think this PR and the numpy 2.0 build #2366 are the only two PRs needed before we can release, so if those go in I think we should release to prepare for Python 3.12+ and numpy 2.0+.

@greglucas
Copy link
Contributor Author

🤔 There is a lot of flakiness going on in the tests right now too. I had to rerun failed jobs a few times before they succeeded, and they are on image comparison tests without network requirements which seems odd to me.

Cartopy has been relicensed from LGPL-3 to BSD-3-Clause. All contributions
to Cartopy are now under the BSD-3-Clause license.

Python 3.12 is now supported and the new minimum supported versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention numpy 2.0 in here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good suggestion. Just added that note.

@rcomer rcomer merged commit cb95b51 into SciTools:main Apr 10, 2024
23 checks passed
@greglucas greglucas deleted the doc-v0.23 branch April 11, 2024 03:23
@QuLogic QuLogic added this to the 0.23 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants