Center the cartopy text in the logo #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry @greglucas, in my attempt to fast-forward 4 years of commits and a rename from the Related to closed PR #1590. |
|
I think it should be good with the CLA now. Let me know if there is anything else to do. |
|
#2460 (comment) |
philippemiron
force-pushed
the
center_logo
branch
from
4d22df5
to
088d948
Compare
|
Thanks @philippemiron! Sorry that took so long to get in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the script that generates the logo in the example, and used it to output a new png icon.
Rationale
Fix issue #1465. The code to centered the logo is here. I updated the offset (longitude, latitude) values in the script.
Implications
The logo is now centered and the png and logo.py script output match.