MNT: Extract all NE resources from the zip file #2477
+3
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The various Natural Earth datasets can have different file members within them. Rather than explicitly iterating through the list of expected files, lets just extract all of them. This adds a
datasetname.README.txt
anddatasetname.VERSION.txt
which could be helpful for debugging purposes too and the sizes are very small for the extra files.closes #2319
Implications