Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty paths raising exception when being converted to shapely geometry. #560

Merged
merged 1 commit into from
Feb 20, 2015

Conversation

pelson
Copy link
Member

@pelson pelson commented Feb 19, 2015

No description provided.

@rhattersley
Copy link
Member

Phil Elson Fixed a corner case that I've witnessed, but cannot reproduce.

Umm... how do you know it's fixed then? 😕

@pelson
Copy link
Member Author

pelson commented Feb 19, 2015

Umm... how do you know it's fixed then?

Fair question 👍 . I was able to sit on the machine and fiddle with the source and see that it fixed the problem. Picking up the data wasn't practical, and it happened a month or so ago. I did try to reproduce with 2 empty paths, but failed.

Having looked again, I can reproduce a similar problem, which serves as a sufficient test. Test incoming.

@pelson pelson added this to the v0.12.0 milestone Feb 19, 2015
@pelson pelson changed the title Fixed a corner case that I've witnessed, but cannot reproduce. Empty paths raising exception when being converted to shapely geometry. Feb 19, 2015
pelson added a commit that referenced this pull request Feb 20, 2015
Empty paths raising exception when being converted to shapely geometry.
@pelson pelson merged commit 40f1535 into SciTools:master Feb 20, 2015
@pelson pelson deleted the empty_path_to_geom branch February 20, 2015 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants