-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt cython3 (require >=3) #460
Conversation
@trexfeathers I think this may possibly be all that is needed ? So far, this adopts exactly what Bill proposed :
But .. I'm still not sure it wouldn't be better to simply unpin Cython, and leave the language-level explicit (which is then not superfluous). Particularly as I see that the build does raises a warning about the default having changed recently. What do you think ? |
Updated to enable macos-14 (hopefully 🤞 ) |
Initial attempt got a failure from setuptools-scm, which failed to identify the version. But it fails again on retry. Can't easily work out whether it is essentially a timeout, or maybe a timeout due to something else failing. |
Updated again to pick up the git-path fix (i.e. #464) |
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#425) Adopt cython3 (require >=3) (SciTools#460) Add repo-review (SciTools#456) Fully support Python 3.12 (SciTools#461) Bump peter-evans/create-pull-request from 6.0.4 to 7.0.5 (SciTools#459) Fix for bad git path in GHA macos instances. (SciTools#464) test macos wheels (SciTools#458) Bump pypa/cibuildwheel from 2.20.0 to 2.21.1 (SciTools#457) Fixes for CI wheels (SciTools#455) Dependabot check weekly. (SciTools#439) # Conflicts: # .pre-commit-config.yaml # cf_units/tests/test_coding_standards.py # pyproject.toml
🚀 Pull Request
Description