Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SciTools/cf-units#464 #492

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trexfeathers
Copy link
Collaborator

Closes #465

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@54b2819). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage        ?   90.37%           
=======================================
  Files           ?        6           
  Lines           ?      800           
  Branches        ?       93           
=======================================
  Hits            ?      723           
  Misses          ?       64           
  Partials        ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member

pp-mo commented Oct 30, 2024

Re-spun + still failing, Oct 30th.

Despite notes in #465 that actions/runner-images#10647 and actions/runner-images#10624 should address it, fix apparently merged Sep 20 and latest release Oct 23rd.

Guess this will just stay in for now.

@pp-mo pp-mo marked this pull request as draft October 31, 2024 11:00
@pp-mo
Copy link
Member

pp-mo commented Oct 31, 2024

I've converted this to draft, since it seems the world isn't ready for us to do this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

remove git path hack
2 participants