Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MEAN with weights lazy #3299

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

bouweandela
Copy link
Member

Closes #3129

Note that this does require at least version 1.1.0 of dask, I'm not sure if that is something you want.

@SciTools-assistant SciTools-assistant added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Mar 28, 2019
@bouweandela
Copy link
Member Author

I have just signed the CLA.

@valeriupredoi
Copy link

there should be no conflicts on version since I have been using dask=1.1.1 for a while now and conda is not complaining wrt iris-dask interdependency; pinning is needed for the func to work tho as @bouweandela says

@valeriupredoi
Copy link

also linking the original ESMValTool issue so we can close that when this gets merged https://github.com/ESMValGroup/ESMValTool/issues/887

@mo-g
Copy link

mo-g commented Mar 28, 2019

I'm assuming (not knowing offhand) that dask doesn't have any excessively complex dependencies of it's own?

Just thinking of installs on older platforms like EL7, SLES11, etc.

@bouweandela
Copy link
Member Author

The dask unit tests are running on Travis with Trusty Tahr, released in 2014, but they use conda to install their dependencies.

@bouweandela
Copy link
Member Author

The iris unit tests are also failing for the master branch.

@bjlittle bjlittle self-assigned this Jun 4, 2019
@SciTools-assistant SciTools-assistant removed the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Jun 4, 2019
@bjlittle bjlittle added this to the v2.3.0 milestone Jun 4, 2019
@bjlittle
Copy link
Member

bjlittle commented Jun 4, 2019

@bouweandela Could you rebase please? We've now merged back out 2.2.x branch onto master after the recent 2.2.1 release

@bjlittle
Copy link
Member

@bouweandela I'm going to make a PR on your branch (for this PR) to add some tests, is that okay?

@bouweandela
Copy link
Member Author

Sure! I hadn't realized that there were separate tests for lazy and non-lazy operators.

@valeriupredoi
Copy link

greetings iris peeps 😁 Is this going to be part of the iris=2.3 release? 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy MEAN Aggregator doesn't support weights
5 participants