Allow non-float cell measures #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
force-pushed
the
cell_measure_ints
branch
from
797199f
to
23d05f8
Compare
bjlittle
reviewed
Oct 1, 2019
| self.var_name = var_name | ||
|
|
||
| #: Unit of the quantity that the coordinate represents. | ||
| #: Unit of the quantity that the cell measure represents. |
There was a problem hiding this comment.
@lbdreyer Nice spot... clearly cut'n paste syndrom 🤣
|
@lbdreyer Nice one, looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not allow the creation of cell measures with non-float data as it is claimed that this is not supported until CF1.7
As of #3406 we are now committed to CF1.7 so we can now support this.
It is worth mentioning that I struggled to find reference to the
in the CF documenstation. But regardless, we can remove this restriction now.