-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add projection argument to Reference.fetch() #380
Add projection argument to Reference.fetch() #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a minor comment.
The issue you point to points to #98 which raises concerns about projection and caching mechanism. And the fact that DB names should be expected (unless umongo tries to translates field names into DB names but I think it wouldn't be the only place where DB names are needed).
In any case, you may merge this if you're happy with it. If we can't have a perfect solution, this is better than nothing. It would be nice if known limitations were documented, though.
@lafrech I've implemented Other things discussed in #98:
|
Not implemented in txmongo yet, having some package compatibility issues
FYI, the suggestion to not use In my application, I have a parent document which references over a thousand others. The time to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You may merge and release!
@lafrech how do I make the CI "go" on this? |
That's a good question. I see no obvious reason. Hooks are enabled. Can't look into this right now. Frankly, Azure CI is a nightmare to configure and rather than trying to fix this I'd be tempted to move to GitHub actions. You may give it a try in another PR if you want. Setting up tests is relatively straightforward. See what I did on flask-smorest. The tricky part would be launching MongoDB. OK I peeked into Azure logs and CI did go but apparently didn't comment here with the results. Note sure if the pipeline logs there are public. Here's the last result:
|
I don't know where to find the link to these results, so I can't tell you if they're public or not :) I fixed the too-long lines. Merging now! As far as a release goes - what is the process on this project? |
Adds projection argument to
Reference.fetch()
, allowing partial reference documents to be returned.Addresses half of issue #196