Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protonvpn-np: Updated the manifest. #204

Merged
merged 4 commits into from
Jun 16, 2023
Merged

protonvpn-np: Updated the manifest. #204

merged 4 commits into from
Jun 16, 2023

Conversation

FlawlessCasual17
Copy link
Contributor

Updated the URL, hash, added architecture, updated the pre_install & pre_uninstall scripts, and updated license.

@FlawlessCasual17 FlawlessCasual17 changed the title protonvpn-np: Updated the manifest protonvpn-np: Updated the manifest. Jun 16, 2023
@FlawlessCasual17
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

protonvpn-np

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@FlawlessCasual17
Copy link
Contributor Author

FlawlessCasual17 commented Jun 16, 2023 •
edited
Loading

@HUMORCE I hope I am not asking for much, but could you please merge this PR? It's a very important and significant change to the protonvpn-np manifest.

EDIT: Could you also merge this PR as well please? #189

@FlawlessCasual17 FlawlessCasual17 mentioned this pull request Jun 16, 2023
Closed
1 task
HUMORCE
HUMORCE approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@HUMORCE HUMORCE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in VM.

@HUMORCE HUMORCE merged commit 3bfaf0c into ScoopInstaller:master Jun 16, 2023
@FlawlessCasual17
Copy link
Contributor Author

Thank you, @HUMORCE, have a great day.

@FlawlessCasual17 FlawlessCasual17 deleted the patch-11 branch June 16, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HUMORCE HUMORCE HUMORCE approved these changes

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlawlessCasual17 @HUMORCE