[Bug] innounp still used by default, rather than innounp-unicode

[wickles]

Bug Report

Current Behavior

#6028 was supposed to make innounp-unicode the default inno helper but it does not seem to be working as intended.

I updated scoop to 0.5.0, uninstalled innounp and tried to install ollama with the same results as in ScoopInstaller/Main#5920 because it still installs and uses innounp instead of innounp-unicode.

> scoop --version
Current Scoop version:
716b6db3 (HEAD -> master, tag: v0.5.0, origin/master, origin/HEAD) chore(release): Bump to version 0.5.0 (#6035)
...
> scoop install ollama
Installing 'innounp' (0.50) [64bit] from 'main' bucket
Loading innounp050.rar from cache.
Checking hash of innounp050.rar ... ok.
Extracting innounp050.rar ... done.
Linking ~\scoop\apps\innounp\current => ~\scoop\apps\innounp\0.50
Creating shim for 'innounp'.
'innounp' (0.50) was installed successfully!
Installing 'ollama' (0.1.48) [64bit] from 'main' bucket
Loading OllamaSetup.exe from cache.
Checking hash of OllamaSetup.exe ... ok.
Extracting OllamaSetup.exe ... ERROR Exit code was 1!
Failed to extract files from C:\Users\me\scoop\apps\ollama\0.1.48\OllamaSetup.exe.
Log file:
  ~\scoop\apps\ollama\0.1.48\innounp.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Main/issues/new?title=ollama%400.1.48%3a+decompress+error

Expected Behavior

innounp-unicode should be installed and used as the default inno helper now.

Additional context/output

After I manually installed innounp-unicode it is now used as expected.

Possible Solution

System details

Windows version: 11

OS architecture: 64bit

PowerShell version: 7.4.3

Additional software: [(optional) e.g. ConEmu, Git]

Scoop Configuration

{
  "last_update": "2024-07-04T21:48:43.8714325-07:00",
  "aria2-warning-enabled": false,
  "scoop_branch": "master",
  "scoop_repo": "https://github.com/ScoopInstaller/Scoop"
}

[qwertyhjklxyz]

It seems that innounp-unicode complements innounp, not replaces it, because innounp-unicode is in the versions repository rather than the main repository.

[kjxbyz]

@qwertyhjklxyz How do I specify innounp-unicode when running scoop install?

[qwertyhjklxyz]

How do I specify innounp-unicode when running scoop install?

scoop install cannot specify which innounp to use.
When innounp-unicode is installed, it will use innounp-unicode instead of innounp.

[kjxbyz]

It doesn't work for me.

[wickles]

Try uninstalling innounp as well.

[niheaven]

Just install innounp-unicode, if installed, scoop will use it as default.

[kcrkor]

It might be worth considering adding innounp-unicode as a default package for Scoop. The standard innounp is still causing issues, as seen in the many decompress errors across the extras bucket. Many of these stem from the ongoing InnoSetup problem. Requiring users to add the version bucket for innounp-unicode adds unnecessary steps and hassle, making installation less seamless. Defaulting to innounp-unicode could solve this issue and improve user experience.