Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scoop-nsis #2546

Closed
wants to merge 1 commit into from
Closed

add scoop-nsis #2546

wants to merge 1 commit into from

Conversation

idleberg
Copy link

No description provided.

@r15ch13
Copy link
Member

r15ch13 commented Aug 31, 2018

Nice!
Some suggestions:

  • shortcuts property requires a name
"shortcuts": [
        [
            "NSIS.exe",
            "NSIS"
        ]
    ]
  • the hash property should only contain one checksum per item in url. In this case, Scoop will only check with the md5. The sha1 from SourceForge should be preferred (it can be extracted from the HTML source).

@se35710
Copy link
Contributor

se35710 commented Sep 5, 2018

What about scoop install nsis@<version>, eg scoop install [email protected]? Would that not remove the necessity of a separate nsis repository?

@idleberg
Copy link
Author

idleberg commented Sep 5, 2018

If it's possible, I would like that much better. I looked at other buckets (e.g. PHP) and how they do it and followed their model.

@se35710
Copy link
Contributor

se35710 commented Sep 5, 2018

That used to be possible with scoop, but installing multiple versions alongside seems to be broken now @r15ch13 @rasa

Also, this issue needs to be fixed. And this would also be a nice feature to have.

PS C:> scoop install [email protected]
WARN  Given version (2.11) does not match manifest (3.03)
WARN  Attempting to generate manifest for 'nsis' (2.11)
Autoupdating nsis
Found: sha1:67114175c443c3b2b3181a83ca6ed5614ff81e05 using Sourceforge Mode
Writing updated nsis manifest
Installing 'nsis' (2.11) [64bit]
[...]
Download: (OK):download completed.
Checking hash of nsis-2.11.zip ... ok.
Extracting nsis-2.11.zip ... done.
Linking ~\scoop\apps\nsis\current => ~\scoop\apps\nsis\2.11
Creating shim for 'makensis'.
Creating shim for 'nsis'.
Creating shortcut for NSIS (NSIS.exe)
Creating shortcut for NSIS Compiler Interface (makensisw.exe)
Creating shortcut for NSIS Zip2Exe (zip2exe.exe)
Persisting nsisconf.nsh
'nsis' (2.11) was installed successfully!
PS C:> scoop install [email protected]
WARN  'nsis' (2.11) is already installed.
Use 'scoop update nsis' to install a new version.
PS C:> scoop install [email protected]
WARN  'nsis' (2.11) is already installed.
Use 'scoop update nsis' to install a new version.

@idleberg
Copy link
Author

Where can I find detailed information how this can be done? Do I simply tag my manifests?

@rashil2000
Copy link
Member

A bucket for a single app does not make much sense. nsis is present in the Extras bucket. For older versions, please make PR in Versions bucket.

@rashil2000 rashil2000 closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants