Add multiple URL support for autoupdate

[rasa]

Fixes (?) #2757. See also ScoopInstaller/Extras#1459

[rasa]

Tested and working with
ScoopInstaller/Extras#1836
Ready for further testing or merging/

[Ash258]

I will look into it in today and tommorow and give some feedback

[niheaven]

A hashExtractionOrArrayOfHashExtrasctions should be added in dshema.json that looks like:

"hashExtractionOrArrayOfHashExtrasctions": {
    "anyOf": [
        {
            "$ref": "#/definitions/hashExtraction"
        },
        {
            "items": {
                "$ref": "#/definitions/hashExtraction"
            },
            "minItems": 1,
            "type": "array",
            "uniqueItems": true
        }
    ]
},

and change hash's $ref to hashExtractionOrArrayOfHashExtrasctions in autoupdate so as to enable multiple hash extraction in au.

There might be some tweaks in hash extraction handling for multiple URL autoupdate, e.g. using same hash extraction formula for multi-files, or some other variations. Let's think about it~

[rasa]

@niheaven Good catch! I'll add it now.

[rasa]

It's working, but the order of the hashes is wrong.
It works using
https://github.com/lukesampson/scoop-extras/blob/c2c626f01180db3abd6561be589873126aac3ca5/bucket/kitty.json
and
https://gist.githubusercontent.com/rasa/a56ba2e8b2517ff5ba630bb917ac1940/raw/e60123ab80673972740380fb2afc2c06dc720387/kitty-0.70.0.9-checksums.txt

[rasa]

To get all the other .jsons to validate, we need to change

        "uriOrArrayOfUris": {
            "anyOf": [
                {
                    "format": "uri",
                    "not": {
                        "pattern": "(\\$)"
                    },

to

        "uriOrArrayOfUris": {
            "anyOf": [
                {
                    "format": "uri",

or

        "uriOrArrayOfUris": {
            "anyOf": [
                {
                    "format": "uri",
                    "not": {
                        "pattern": "(^\\$)"
                    },

Is this pattern here to avoid empty URLs? If so, then doesn't ^\\$ make more sense?

[r15ch13]

No that pattern disallows URLs containing $, so the autoupdater can't slip an unresolved variable in 😄

[rasa]

@r15ch13 Two points:

1. Autoupdate URLs have dollar signs
2. Dollar signs are allowed in URLs, per here

I've addressed 1. in the schema. Let's ignore 2. for now.

[Ash258]

Small tweak by static review. There is some code duplicacy, which I think could be removed and simplified, but i need to think about it little bit more.

[niheaven]

Now the codes are applied to noarch, and they should be copied to arch-32 and arch-64 too.

BTW, the hash handling part is insufficiency, I thought, and a specialized function to handle multiple hash extracting methods may help. I'm trying to make one, but maybe later.

[niheaven]

Suggestion about reusing hash extraction expression and applying lets_do_autoupdates to au.arch.

[niheaven]

Suggested change

	} else {
	} elseif ($json.autoupdate.hash.length -ne 0) {
	$h = $json.autoupdate.hash[-1]
	} else {

If hash's length is less than url, the last hash expression is reused for remaining urls.

So we could use one hash expression for all these urls if hash extraction url and regex are the same, e.g., $sha256.*?$basename, different hashes for different $basenames.

[niheaven]

This if...else... should be applied to $json.architecture's ForEach-Object script too.

[niheaven]

@rasa Could I keep on working with multi-urls and hashes autoupdate support based on this PR?

[rasa]

@rasa Could I keep on working with multi-urls and hashes autoupdate support based on this PR?

Sure! Sorry I dropped the ball on implementing your suggestions.

[rasa]

Moved to #3518