fix(decompress): Remove parent dir when extract_dir is nested dir #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niheaven
reviewed
Nov 22, 2019
| if (!$IsTar -and $ExtractDir) { | ||
| $OriDestinationPath = $DestinationPath | ||
| $DestinationPath = "$DestinationPath\_tmp" |
There was a problem hiding this comment.
You could use Join-Path to avoid using TrimEnd("\").
There was a problem hiding this comment.
I just keep it consistent with other expanders. Should I change all of them?
There was a problem hiding this comment.
Could you try if the script works without TrimEnd("\")? i.e. if 7-zip recognize aaa\\temp. I trim \ in msi's since #3466 (comment), and Expand-Archive use aaa\\_tmp as aaa\_tmp so it doesn't need trim end.
There was a problem hiding this comment.
It works. I got, I'll remove it. Thanks!
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extract_dir is nested dir, the parent dir won't be removed by movedir.
Test with
kubectlandwire.