Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decompress): Fix 'Expand-7zipArchive()' for nested archive #4582

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

niheaven
Copy link
Member

After we added error log in 7zip.log (#4570), nested archive extraction by 7-zip had been broken... This PR fix it.

Besides, output and error logs have some encoding error as in #4569, and change encoding to Default solve my problem (CP936, in PS 7 and PS 5), please test it in different codepage and PowerShell version.

@rashil2000
Copy link
Member

I was facing errors with extracting tar.xz URL yesterday and wasted a lot of time... Had no idea it was related to redirecting stderr

@niheaven niheaven merged commit cd6d31d into develop Dec 15, 2021
@niheaven niheaven deleted the fix-7zip-extraction branch December 15, 2021 03:38
niheaven added a commit that referenced this pull request Dec 25, 2021
Related PRs:
- #4531 @filmor 
  - ac71fcc @niheaven 
- #4535 @rashil2000 
- #4522 @pratikpc 
- #4550 @niheaven 
- #4528 @niheaven 
- #4532 @MrNuggelz
- #4155 @MrNuggelz Co-authored-by: @rashil2000 
  - #4581 @niheaven 
  - fb496c4 @rashil2000 
- #4543 @rashil2000 Co-authored-by: @niheaven 
  - #4555 @rashil2000 
  - 3c90d1a @rashil2000 
  - 2ec00d5 @rashil2000 
- #4567 @rashil2000 
  - cbe29ed @rashil2000 
- #4570 @niheaven 
  - #4582 @niheaven 
- #4571 @niheaven 
- #3244 @nickbudi 
- #3821 @jfastnacht Co-authored-by: @rasa 
- #4578 @tukanos
- #4579 @rashil2000 

Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Rashil Gandhi <[email protected]>
Co-authored-by: Jakub Čábera <[email protected]>
Co-authored-by: Ross Smith II <[email protected]>
Co-authored-by: Benedikt Reinartz <[email protected]>
Co-authored-by: Joris <[email protected]>
Co-authored-by: Pratik Chowdhury <[email protected]>
Co-authored-by: Rashil Gandhi <[email protected]>
Co-authored-by: nickbudi <[email protected]>
Co-authored-by: Julian <[email protected]>
Co-authored-by: tukanos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants