fix(install): Limit HTTP redirects #5758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a misconfigured download server responds with invalid/infinite redirects, Scoop follows them and gets stuck in a loop. This PR limits the redirects to 20.
Motivation and Context
Closes #5757
How Has This Been Tested?
url.scoop update screenpressowith originalinstall.ps1-> infinite loops are being followed.scoop update screenpressowithinstall.ps1from this PR -> error is thrown after 20 redirects.Checklist:
developbranch.