fix(CI): Trigger CodeQL on everything except the "push" event for Dependabot branches #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottBrenner
added
bug
ScottBrenner
changed the title
ScottBrenner
commented
Jun 12, 2021
| @@ -2,9 +2,8 @@ name: "CodeQL" | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ main, v* ] | |||
| branches-ignore: dependabot/** | |||
There was a problem hiding this comment.
Admittedly not sure if this would resolve the errors as it appears to be failing on push events to main - https://github.com/ScottBrenner/cfn-lint-action/actions/workflows/codeql-analysis.yml?query=event%3Apush
However https://github.com/ScottBrenner/cfn-lint-action/runs/2764966785?check_suite_focus=true#step:3:55 does say avoid triggering on the "push" event for Dependabot branches
ScottBrenner
commented
Jun 12, 2021
| @@ -2,9 +2,8 @@ name: "CodeQL" | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ main, v* ] | |||
| branches-ignore: dependabot/** | |||
| pull_request: | |||
There was a problem hiding this comment.
Suggested change
| pull_request: |
This could be removed as push would now trigger for all branches
ScottBrenner
changed the title
NickLiffen
previously approved these changes
Jun 14, 2021
|
✅ |
|
@ScottBrenner sorry for not approving this 🤦 I meant to 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CodeQL workflow fails on the "push" event for Dependabot branches - https://github.com/ScottBrenner/cfn-lint-action/actions/workflows/codeql-analysis.yml with an error message like:
(https://github.com/ScottBrenner/cfn-lint-action/runs/2764966785?check_suite_focus=true#step:3:55)
So, this pull request proposes ignoring the "push" event for Dependabot branches.
Additionally removing specific branches for trigger events, don't we want this to run everywhere?
Other Information
Reference: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags