fix(screeb-sdk-react): fix surveyStart helper typing #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋, It is indeed an oversight on our part. Thanks for the PR ! |
|
Thanks for the quick answer! |
|
I just published the version 0.1.12 with the fix |
|
Thanks, I'm waiting for the version on npm registry ( => https://www.npmjs.com/package/@screeb/sdk-react?activeTab=versions |
|
Hi @vincsb 👋 |
|
👋 @MD4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋,
I'd like to suggest a change on the
surveyStarttype definition in@screeb/sdk-reactpackage.Since this recent commit e2f4b6c a new param has been added to the function signature (
language) and it seems optional like thehooksparam.It seems to have an inconsistency between the implementation and the type definition in
packages/screeb-sdk-react/src/types.ts.In this type,
hooksandlanguagewas added as mandatories.I can be wrong but this looks like a breaking change when using the sdk because 2 news params are now mandatories and we can't upgrade until we use it (even the
hooks).Can you consider this and having a look?
Thanks for your help 🙏