Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node > 12 compatibility #310

Merged
merged 1 commit into from
May 5, 2020
Merged

Node > 12 compatibility #310

merged 1 commit into from
May 5, 2020

Conversation

dcsaszar
Copy link
Contributor

@dcsaszar dcsaszar commented May 5, 2020

Module build failed (from ../node_modules/babel-loader/lib/index.js):
Error: Cannot find module '@babel/compat-data/corejs3-shipped-proposals'
Require stack:
- ~/scrivito_example_app_js/node_modules/@babel/preset-env/lib/polyfills/corejs3/usage-plugin.js

Solution found here:
storybookjs/storybook#10477 (comment)

```
Module build failed (from ../node_modules/babel-loader/lib/index.js):
Error: Cannot find module '@babel/compat-data/corejs3-shipped-proposals'
Require stack:
- ~/scrivito_example_app_js/node_modules/@babel/preset-env/lib/polyfills/corejs3/usage-plugin.js
```

Solution found here:
storybookjs/storybook#10477 (comment)
@apepper apepper self-assigned this May 5, 2020
Copy link
Contributor

@apepper apepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (8840241)

Good job 🚀!

@apepper apepper merged commit dfb5195 into master May 5, 2020
@apepper apepper deleted the dave-nodejs-14 branch May 5, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants