Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow an easier use of limit/offset #2164

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctron
Copy link

@ctron ctron commented Mar 19, 2024

This is a draft PR and it lacks some things to fix up before merging. I just want to understand if that's going the right direction.

PR Info

New Features

  • Add an easier way working with limit & offset

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ctron, thanks for contributing!!

Sorry, I don't quite understand the exact usage of the Limiter after reading #2163 and this PR. Could you please elaborate?

@ctron
Copy link
Author

ctron commented May 2, 2024

Right now, one can use page_size and start_page. However, there seems to be no simple way to use limit and offset.

The idea is to provide a simple way to set limit and offset, which is a more basic version. That could then (not part of this PR yet) be used to implement pagination on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants