Returning

[billy1624]

• Resolve Support returning clause to avoid database hits #183

[billy1624]

Hey @tyt2y3, checkout the support of returning for Postgres.

[billy1624]

Got this error on MariaDB 10.5+

• The error is from SQLx
  • [MariaDB 10.5] Fail to get row value by column name launchbadge/sqlx#1530
• https://github.com/SeaQL/sea-orm/runs/4147966480#step:6:211

[2021-11-09T04:31:54Z DEBUG sea_orm::driver::sqlx_mysql] INSERT INTO `active_enum` (`category`, `color`, `tea`) VALUES (NULL, NULL, NULL) RETURNING `id`, `category`, `color`, `tea`
[2021-11-09T04:31:54Z INFO  sqlx::query] INSERT INTO `active_enum` (`category`, …; rows: 1, elapsed: 1.526ms
    
    INSERT INTO
      `active_enum` (`category`, `color`, `tea`)
    VALUES
      (?, ?, ?) RETURNING `id`,
      `category`,
      `color`,
      `tea`
    
Error: Query("no column found for name: id")
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/59eed8a2aac0230a8b53e89d4e99d55912ba6b35/library/test/src/lib.rs:194:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[billy1624]

Now I'm stuck on the SQLx problem... I'm thinking maybe we just support returning for Postgres at this stage. We can leave MariaDB & Sqlite as-is, i.e. one more round trip per insert / update, if it involve updating sqlx-core.

[billy1624]

The issue not only affecting MariaDB 10.5+ but SQLite 3.35.0+

• MariaDB: https://github.com/SeaQL/sea-orm/runs/4150761196
• SQLite: https://github.com/SeaQL/sea-orm/runs/4150793637

[billy1624]

Just open another issue on SQLx

• [SQLite 3.35.0+] Getting row values from RETURNING statement launchbadge/sqlx#1531

[billy1624]

As discussed, we would only support RETURNING on Postgres at this stage. And leaving MySQL & SQLite for later.

[billy1624]

Ready for review & merge @tyt2y3

[tyt2y3]

SO we need new test cases here.

[billy1624]

Yep!

[billy1624]

Test cases added

[tyt2y3]

Nice