Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertisement announce/lookup failure in CoordinationAffix causes it to believe the server is a legacy node. #15

Open
monzum opened this issue Sep 30, 2013 · 1 comment

Comments

@monzum
Copy link
Contributor

monzum commented Sep 30, 2013

If the server is using the AFFIX framework and if it either fails to advertise the AFFIX string or if the client is unable to perform advertise lookup for the server node, the client believes that the server is a legacy node and will try to contact it using an empty stack. This could cause the message being sent and the message being received to be a mismatch and neither the server or client would know any better.

Example: Server uses AsciiShiftingAffix and successfully announces the AFFIX string using the CoordinationAffix. Client uses CoordinationAffix to do a lookup for the server's AFFIX string but gets an empty list back. Thus client believes that server is using a legacy connection and uses an empty stack. Due to the AFFIX stack being imbalanced on both sides, the application on the server side will receive a garbled message.

Is this the desired effect that we want?

@JustinCappos
Copy link
Contributor

Definitely not.

Perhaps the server should essentially have a branching shim? In practice,
you'll want different connections (port, etc.) for legacy and non-legacy.

On Mon, Sep 30, 2013 at 11:41 AM, monzum [email protected] wrote:

If the server is using the AFFIX framework and if it either fails to
advertise the AFFIX string or if the client is unable to perform advertise
lookup for the server node, the client believes that the server is a legacy
node and will try to contact it using an empty stack. This could cause the
message being sent and the message being received to be a mismatch and
neither the server or client would know any better.

Example: Server uses AsciiShiftingAffix and successfully announces the
AFFIX string using the CoordinationAffix. Client uses CoordinationAffix to
do a lookup for the server's AFFIX string but gets an empty list back. Thus
client believes that server is using a legacy connection and uses an empty
stack. Due to the AFFIX stack being imbalanced on both sides, the
application on the server side will receive a garbled message.

Is this the desired effect that we want?


Reply to this email directly or view it on GitHubhttps://github.com//issues/15
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants