Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

add all fields from chore details api call #98

Merged
merged 5 commits into from
May 25, 2020
Merged

add all fields from chore details api call #98

merged 5 commits into from
May 25, 2020

Conversation

SebRut
Copy link
Owner

@SebRut SebRut commented May 25, 2020 •
edited
Loading

Description

Adds missing fields for GET /chores/{choreId}

Related issue (if applicable): fixes #87

Checklist

  • The code change is tested and works locally.
  • tests pass. Your PR won't be merged unless tests pass
  • There is no commented out code in this PR

@pull-assistant
Copy link

pull-assistant bot commented May 25, 2020 •
edited
Loading

Score: 0.98

Best reviewed: commit by commit

Optimal code review plan

     add all fields from chore details api call

     fix test

     fix test

     fix test

     expand test for user

Powered by Pull Assistant. Last update 704e44d ... 366c0f7. Read the comment docs.

@SebRut SebRut marked this pull request as ready for review May 25, 2020 11:56
@SebRut SebRut merged commit 6f54d3d into develop May 25, 2020
@SebRut SebRut deleted the feature/87-complete_chore_details_api branch May 25, 2020 11:58
@SebRut SebRut restored the feature/87-complete_chore_details_api branch November 16, 2020 12:41
@SebRut SebRut deleted the feature/87-complete_chore_details_api branch November 16, 2020 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement chore details API interface
1 participant
@SebRut