Don't use the deprecated LoggerInterfaceTest class #1565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Signed-off-by: Alexander M. Turek <[email protected]>
derrabus
force-pushed
the
remove/deprecated-test-class
branch
from
9d0acba
to
1b0d5e5
Compare
|
I think I'd rather wait on php-fig/log-util#2 to be finished so we can rely on that instead of copy pasting it all in here.. I don't think supporting psr/log 2.0 is that urgent? |
|
Not sure if it's urgent to support psr/log 2.0, but as we do support it in Symfony, 2.0 is installed by default and then, doing |
|
It does not look like php-fig/log-util#2 is actively being worked on. Given that the amount of code I'm inlining here is not really much and we're talking about a test case, shall we merge anyway? |
|
Right, log-util seems stalled so I merged #1587 now which does pretty much the same as this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psr\Log\Test\LoggerInterfaceTestis deprecated and has been removed inpsr/log2.0. This PR inlines the test cases from that class. That should unlock #1564.