-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Lock GitHub runners' OS #1765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sorting it out! I left comments, once they are resolved then PR is good to go.
Going to merge in, based on the latest results [1]. It looks like the new Docker setup still needs some work, based on the error message [2]. [1] https://github.com/SeldonIO/MLServer/actions/runs/9302553271?pr=1765
|
This was motivated by our macOS jobs failing [2] because colima is missing. It looks like this is because the latest versions of the macOS runner no longer have colima installed by default [1]. colima is now explicitly installed. [1] actions/runner-images#6216 [2] `/Users/runner/work/_temp/f19ffbff-27a9-4fc7-80b6-97791d2de141.sh: line 9: colima: command not found`
The > 0.6.0 releases actually fix the issue we have linked [1][2][3]. [1] abiosoft/colima#577 [2] https://github.com/jesse-c/MLServer/blob/c3acd60995a72141027eff506e4fd330fe824179/hack/install-docker-macos.sh#L18-L20 [3] > Switch to new user-v2 network. Fixes abiosoft/colima#648, abiosoft/colima#603, abiosoft/colima#577, abiosoft/colima#779, abiosoft/colima#137, abiosoft/colima#740.
This was motivated by our macOS jobs failing [2] because colima is missing. It looks like this is because the latest versions of the macOS runner no longer have colima installed by default [1].
colima is now explicitly installed. The incompatible
--network-driver
argument for this version of colima has been removed as well.Since macOS isn't used for PRs, I had temporarily disabled that check to see the actions run. For seeing the results, you'll need to look at previous runs for this PR, before I re-enabled the PR check.
I think the way that
poetry install
is done in the workflow description and in the Tox environments seems wrong/duplicative. It ends up taking long as it's duplicated and you can see a mix of upgrades/downgrades done, that could be avoided.[1] actions/runner-images#6216
[2]
/Users/runner/work/_temp/f19ffbff-27a9-4fc7-80b6-97791d2de141.sh: line 9: colima: command not found