Pin sphinx <5.1.0 #722
Merged
Pin sphinx <5.1.0 #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=======================================
Coverage 81.06% 81.06%
=======================================
Files 105 105
Lines 11793 11794 +1
=======================================
+ Hits 9560 9561 +1
Misses 2233 2233
|
ascillitoe
reviewed
Jul 25, 2022
requirements/docs.txt
Outdated
| @@ -1,6 +1,6 @@ | |||
| # dependencies for building docs, separate from dev.txt as this is also used for builds on readthedocs.org | |||
| # core dependencies | |||
| sphinx>=4.2.0, <6.0.0 # Enforce 4.x sphinx version so that mathjax works correctly | |||
| sphinx>=4.2.0, <5.1.0 # Enforce 4.x sphinx version so that mathjax works correctly | |||
There was a problem hiding this comment.
Can we remove the # Enforce 4.x sphinx version so that mathjax works correctly comment at the same time?
ascillitoe
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI failing due to
sphinx==5.1.0. Pin to less than.