Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporary fix for mypy issue in Python 3.10 CI (#761)" #795

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Revert "Temporary fix for mypy issue in Python 3.10 CI (#761)" #795

merged 1 commit into from
Sep 29, 2022

Conversation

ascillitoe
Copy link
Contributor

Revert #761 now that mypy 0.981 is out. See python/mypy#13627 (comment).

Resolves #763.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #795 (9ea7894) into master (3b6756e) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   75.72%   75.60%   -0.13%     
==========================================
  Files          72       72              
  Lines        8224     8190      -34     
==========================================
- Hits         6228     6192      -36     
- Misses       1996     1998       +2     
Flag Coverage Δ
macos-latest-3.10.6 ?
ubuntu-latest-3.10.6 ?
ubuntu-latest-3.7 75.43% <ø> (-0.10%) ⬇️
ubuntu-latest-3.8 75.48% <ø> (-0.10%) ⬇️
ubuntu-latest-3.9 75.48% <ø> (-0.10%) ⬇️
windows-latest-3.9 73.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi/utils/discretizer.py 92.50% <0.00%> (-5.00%) ⬇️
alibi/utils/approximation_methods.py 81.81% <0.00%> (-0.41%) ⬇️
alibi/utils/missing_optional_dependency.py 94.28% <0.00%> (-0.16%) ⬇️
alibi/explainers/anchors/anchor_text.py 94.30% <0.00%> (-0.14%) ⬇️
alibi/explainers/cfrl_base.py 87.79% <0.00%> (-0.09%) ⬇️
alibi/explainers/shap_wrappers.py 92.27% <0.00%> (-0.02%) ⬇️
alibi/api/defaults.py 100.00% <0.00%> (ø)

Copy link
Collaborator

@mauicv mauicv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ascillitoe ascillitoe merged commit 4ce133d into SeldonIO:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor mypy releases and revert to Python 3.10 in CI when issue fixed
2 participants