-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace grid_resolution np.inf value with large number #940
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 85.28% 85.23% -0.05%
==========================================
Files 74 74
Lines 8832 8832
==========================================
- Hits 7532 7528 -4
- Misses 1300 1304 +4 |
The At that time, |
I've updated the sklearn Note: Python 3.7 is technically end-of-life so we should drop support for it (see here). If we do so we could remove the above changes. It's perhaps worth leaving them in case we're testing on supported python versions with sklearn<=-1.3.0. |
Ci failing due to #943 |
I'm in favour of the second option i.e. keeping the conditional sklearn version behaviour in to support running tests with a new Python version but older sklearn version. |
What is this
Fixes CI failing due to sklearn parameter validation in
partial_dependence
functionSklearn has added parameter validation for
partial_dependence
here which we use in the tests for our partial dependence implementation. This means the ci is failing as we setgrid_resolution
tonp.inf
where now Sklearn expects that parameter to be less than infinity.This PR just replaces
np.inf
in the relevant tests to a large number. This is to check if the test suite failed elsewhere. This is still a work in progress.