Switch on executor enabled for service ports

Signed-off-by: glindsell <[email protected]>
SeldonIO · Jun 23, 2020 · 69162b5 · 69162b5
1 parent f597ec4
commit 69162b5
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/operator/controllers/seldondeployment_controller.go b/operator/controllers/seldondeployment_controller.go
@@ -626,12 +626,22 @@ func createPredictorService(pSvcName string, seldonId string, p *machinelearning
 		},
 	}
 
-	if engine_http_port != 0 && len(psvc.Spec.Ports) == 0 {
-		psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_http_port), TargetPort: intstr.FromInt(engine_http_port), Name: "http"})
-	}
+	if isExecutorEnabled(mlDep) {
+		if engine_http_port != 0 && len(psvc.Spec.Ports) == 0 {
+			psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_http_port), TargetPort: intstr.FromInt(engine_http_port), Name: "http"})
+		}
 
-	if engine_grpc_port != 0 && len(psvc.Spec.Ports) < 2 {
-		psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_grpc_port), TargetPort: intstr.FromInt(engine_http_port), Name: "grpc"})
+		if engine_grpc_port != 0 && len(psvc.Spec.Ports) < 2 {
+			psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_http_port), TargetPort: intstr.FromInt(engine_http_port), Name: "grpc"})
+		}
+	} else {
+		if engine_http_port != 0 && len(psvc.Spec.Ports) == 0 {
+			psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_http_port), TargetPort: intstr.FromInt(engine_http_port), Name: "http"})
+		}
+
+		if engine_grpc_port != 0 && len(psvc.Spec.Ports) < 2 {
+			psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_grpc_port), TargetPort: intstr.FromInt(engine_grpc_port), Name: "grpc"})
+		}
 	}
 
 	if GetEnv("AMBASSADOR_ENABLED", "false") == "true" {