Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with the latest release of azure-storage-blob 12.0.0, seldon build fails #1027

Closed
klalit opened this issue Nov 1, 2019 · 5 comments
Closed

Comments

@klalit
Copy link
Contributor

klalit commented Nov 1, 2019

earlier the version was azure-storage-blob 2.1.0 but with latest release on Oct-31-2019. Seldon has a dependency on azure-storage-blob >=2.1.0, the following error is thrown

from azure.storage.blob import BlockBlobService
Traceback (most recent call last):
File "", line 1, in
ImportError: cannot import name 'BlockBlobService'

@ukclivecox
Copy link
Contributor

Should be fixed in https://pypi.org/project/seldon-core/0.5.0.2/

@klalit
Copy link
Contributor Author

klalit commented Nov 1, 2019

one thought... can't we fix the versions in requirements.txt to avoid these kind of scenarios in future..
in master the dependency is still azure-storage-blob >=2.1.0. The better way would be to say fix the version azure-storage-blob ==2.1.0. Please suggest.

@axsaucedo
Copy link
Contributor

Yeah we were discussing this earlier, but we also didn't want to restrict the setup.py dependencies too much as otherwise it can easily clash when other dependencies are brought in (i.e currently Seldon Core works with TF 2.0, we wouldn't want to restrict installations unless they break). We could do this for some dependencies but we'd want to be careful with making it too restrictive...

Specifically on this, we are looking to reduce our dependencies, and specifically on the libraries to access object stores (an other files) we are looking to potentially remove the dependency on Storage.py and use an external library such as Apache Libcloud, wchih is currently being discussed in #885.

@klalit it would be great to hear your thoughts on #885, primarily as this is something that will be driven by what people use most often to download files.

@axsaucedo
Copy link
Contributor

@klalit I am closing all other issues and opening just this one #1028 to evaluate what options we can take for this.

@klalit
Copy link
Contributor Author

klalit commented Nov 1, 2019

@axsaucedo yes we may close this one if another ticket already consolidates similar issues.

@klalit klalit closed this as completed Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants