-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model initializer does not work with S3 #885
Comments
@cliveseldon woudl this require updating to the latest Storage.py file from KFServing? |
Yes we should stay aligned with Storage.py in kfserving |
Needs to be retested |
Explore other libraries to replace kfserving library. |
Apache |
moving discussion into #1028. Stil keeping open as this is still an issue |
Currently a PR has been opened to be able to provide default access to public S3 files kserve/kserve#589 |
As a current fix, it's possible to circumvent this by creating a secret in the same way as the Seldon Docs suggest, adding an S3_ENDPOINT key with the value "s3.amazonaws.com". |
The change has been landed in the KFServing repo - @cliveseldon @ryandawsonuk what would be the best way to reflect that change into the initContainer we use? Would there be a way to do it before the next KFrelease? Or when is the next release? |
Only if we create our own image and use that in Operator I think? |
Got it! Ok, I think we can use the walkaround until the new KFServing image comes out if we don't want to go through creating a new image |
I guess kserve/kserve#589 is the fix (just linking for reference) |
Correct. Closing this as it's now addressed in the next version of kfserving, and we'll be diving further in #1028. |
This was fixed for Kfserving in the main repo with kserve/kserve#213, but it seems the issue still exists when using the pre-packaged model server
The text was updated successfully, but these errors were encountered: