Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model initializer does not work with S3 #885

Closed
axsaucedo opened this issue Sep 25, 2019 · 13 comments
Closed

Model initializer does not work with S3 #885

axsaucedo opened this issue Sep 25, 2019 · 13 comments
Assignees
Labels
Milestone

Comments

@axsaucedo
Copy link
Contributor

This was fixed for Kfserving in the main repo with kserve/kserve#213, but it seems the issue still exists when using the pre-packaged model server

@axsaucedo axsaucedo added the bug label Sep 25, 2019
@axsaucedo
Copy link
Contributor Author

@cliveseldon woudl this require updating to the latest Storage.py file from KFServing?

@ukclivecox
Copy link
Contributor

Yes we should stay aligned with Storage.py in kfserving

@axsaucedo axsaucedo added this to the 0.5.x milestone Oct 10, 2019
@ukclivecox
Copy link
Contributor

Needs to be retested

@ukclivecox
Copy link
Contributor

Explore other libraries to replace kfserving library.

@ukclivecox ukclivecox modified the milestones: 0.5.x, 1.0.x Oct 31, 2019
@adriangonz
Copy link
Contributor

Apache libcloud could be a good alternative worth exploring. One of its caveats is that it may support too many things though.

@axsaucedo
Copy link
Contributor Author

moving discussion into #1028. Stil keeping open as this is still an issue

@axsaucedo
Copy link
Contributor Author

Currently a PR has been opened to be able to provide default access to public S3 files kserve/kserve#589

@axsaucedo
Copy link
Contributor Author

As a current fix, it's possible to circumvent this by creating a secret in the same way as the Seldon Docs suggest, adding an S3_ENDPOINT key with the value "s3.amazonaws.com".

@axsaucedo
Copy link
Contributor Author

The change has been landed in the KFServing repo - @cliveseldon @ryandawsonuk what would be the best way to reflect that change into the initContainer we use? Would there be a way to do it before the next KFrelease? Or when is the next release?

@ukclivecox
Copy link
Contributor

The change has been landed in the KFServing repo - @cliveseldon @ryandawsonuk what would be the best way to reflect that change into the initContainer we use? Would there be a way to do it before the next KFrelease? Or when is the next release?

Only if we create our own image and use that in Operator I think?

@axsaucedo
Copy link
Contributor Author

Got it! Ok, I think we can use the walkaround until the new KFServing image comes out if we don't want to go through creating a new image

@ryandawsonuk
Copy link
Contributor

I guess kserve/kserve#589 is the fix (just linking for reference)

@axsaucedo
Copy link
Contributor Author

Correct. Closing this as it's now addressed in the next version of kfserving, and we'll be diving further in #1028.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants