Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image "seldonio/seldon-core-s2i-python3" uses old Python 3.6 #288

Closed
oshev opened this issue Nov 7, 2018 · 6 comments · Fixed by #290
Closed

Docker image "seldonio/seldon-core-s2i-python3" uses old Python 3.6 #288

oshev opened this issue Nov 7, 2018 · 6 comments · Fixed by #290

Comments

@oshev
Copy link

oshev commented Nov 7, 2018

The latest Python stable release is 3.7. It would be great to have an model serving with the latest Python. Thanks!

@ukclivecox
Copy link
Contributor

This was the issue: tensorflow/tensorflow#20444

Which is referenced in https://github.com/SeldonIO/seldon-core/blob/master/wrappers/s2i/python/build_python3.sh

Need to ensure this is fully fixed. I see the issue is closed.

@oshev
Copy link
Author

oshev commented Nov 7, 2018

Yes, I'm not sure they fixed TF for Python 3.7. I was investigating a bit a couple of weeks ago and it seemed to be WIP but I'm not sure.

However, it's only an issue if you use TF in model serving. In all other cases - PyTorch, XGBoost, Scikit-learn - there is no problem at all.

@ukclivecox
Copy link
Contributor

Maybe one solution is to have multiple variants of the python wrappers for python 3, so python3.6 and python3.7 versions.

@oshev
Copy link
Author

oshev commented Nov 7, 2018

That would be great!

@ukclivecox
Copy link
Contributor

@oshev If you could test the newly pushed python wrapper images - see #290 for details

@oshev
Copy link
Author

oshev commented Nov 8, 2018

I've tried to build new model containers and it seems to work fine! Just in case, tried to SSH into the container and got there Python 3.7 indeed. Thank you so much! That was fast. :-)

@oshev oshev closed this as completed Nov 8, 2018
agrski pushed a commit that referenced this issue Dec 2, 2022
* small update to docs

* num model gateway workers from envar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants