Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make engine probes configurable #525

Closed
ryandawsonuk opened this issue Apr 25, 2019 · 1 comment
Closed

make engine probes configurable #525

ryandawsonuk opened this issue Apr 25, 2019 · 1 comment

Comments

@ryandawsonuk
Copy link
Contributor

Exposing env vars in the cluster manager and making available to the helm chart would do it.

Given that the engine is a sidecar, I personally would like to put its config directly in a configmap populated by the helm chart and have the cluster-manager read the configmap. Like istio does. Then we could expose its config more flexibly.
@ukclivecox
Copy link
Contributor

Closing can reopen if we think engine probes need to be controllable.

agrski pushed a commit that referenced this issue Dec 2, 2022
@sakoush
Quickfix/add paper reference (#525)
cfaaa70 
* improve readme.md

* add paper in About section

* add paper link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ukclivecox @ryandawsonuk