Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate s2i-python2 in examples #593

Closed
jklaise opened this issue May 28, 2019 · 0 comments · Fixed by #1425
Closed

Deprecate s2i-python2 in examples #593

jklaise opened this issue May 28, 2019 · 0 comments · Fixed by #1425
Assignees
Milestone

Comments

@jklaise
Copy link
Contributor

jklaise commented May 28, 2019

Any examples and docs using the Python2 wrapper image should be re-written for Python3 (related to #566), a grep through the repository for s2i-python returned the following:

 grep -nrw . -e 's2i-python2'
./examples/models/deep_mnist/deep_mnist.ipynb:648:    "!eval $(minikube docker-env) && s2i build . seldonio/seldon-core-s2i-python2:0.5.1 deep-mnist:0.1"
./doc/source/tutorials/openshift_s2i.md:92:s2i build <git-repo> seldonio/seldon-core-s2i-python2 <my-image-name>
./doc/source/tutorials/openshift_s2i.md:93:s2i build <src-folder> seldonio/seldon-core-s2i-python2 <my-image-name>
./doc/source/reference/images.md:11:| [Seldon Python 2 Wrapper for S2I](docs/wrappers/python.md) | [seldonio/seldon-core-s2i-python2](https://hub.docker.com/r/seldonio/seldon-core-s2i-python2/tags/) | 0.5.1 | deprecated |
./wrappers/s2i/python/s2i/bin/assemble:10:# If the 'seldon-core-s2i-python2' assemble script is executed with the '-h' flag, print the usage.
./wrappers/s2i/python/s2i/bin/usage:11:s2i build https://github.com/seldonio/seldon-core.git --context-dir=wrappers/s2i/python/test/model-template-app seldonio/seldon-core-s2i-python2 seldon-core-template-model
./wrappers/s2i/python/s2i/bin/usage:22:s2i build https://github.com/seldonio/seldon-core.git --context-dir=wrappers/s2i/python/test/router-template-app seldonio/seldon-core-s2i-python2 seldon-core-template-router
./wrappers/s2i/python/s2i/bin/usage:35:s2i build https://github.com/seldonio/seldon-core.git --context-dir=wrappers/s2i/python/test/transformer-template-app seldonio/seldon-core-s2i-python2 seldon-core-template-transformer
./wrappers/s2i/python/test_fbs/run_test_python2:1:s2i build . seldonio/seldon-core-s2i-python2:0.4 test-wrapper-py2:0.1

@ukclivecox ukclivecox added this to the 1.0.x milestone Aug 23, 2019
@ukclivecox ukclivecox modified the milestones: 1.0, 1.1 Nov 7, 2019
seldondev added a commit that referenced this issue Feb 12, 2020
Update seldon-core-s2i-python2 -> seldon-core-s2i-python3. Closes #593.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants