Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaulting by api-server differences #1214

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Fix defaulting by api-server differences #1214

merged 3 commits into from
Dec 10, 2019

Conversation

ukclivecox
Copy link
Contributor

Fixes #1211

  • Changes how differences are checked for resources to allow for k8s defaulting by the API server
  • Removes the defaults added in the webhook defaulter as no longer needed

@seldondev
Copy link
Collaborator

Fri Dec 6 19:14:10 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=1

@seldondev
Copy link
Collaborator

Fri Dec 6 19:14:23 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=2

@ukclivecox ukclivecox removed the request for review from SachinVarghese December 10, 2019 15:27
@seldondev seldondev removed the lgtm label Dec 10, 2019
@ryandawsonuk
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ryandawsonuk
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Dec 10 16:22:17 UTC 2019
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=3

@seldondev
Copy link
Collaborator

Tue Dec 10 16:22:28 UTC 2019
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=5

@seldondev
Copy link
Collaborator

Tue Dec 10 16:22:41 UTC 2019
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=6

@seldondev
Copy link
Collaborator

Tue Dec 10 16:23:35 UTC 2019
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=4

@seldondev
Copy link
Collaborator

Tue Dec 10 16:23:40 UTC 2019
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=7

@seldondev
Copy link
Collaborator

Tue Dec 10 16:57:39 UTC 2019
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=10

@seldondev
Copy link
Collaborator

Tue Dec 10 16:57:41 UTC 2019
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=11

@seldondev
Copy link
Collaborator

Tue Dec 10 17:05:32 UTC 2019
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=12

@seldondev
Copy link
Collaborator

Tue Dec 10 17:05:36 UTC 2019
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1214/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1214 --build=13

@ukclivecox ukclivecox deleted the 1211_env_bug branch February 14, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeldonDeployment stuck on creating when an environment variable is a reference
3 participants