Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook selector k8s version #1237

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Fix webhook selector k8s version #1237

merged 2 commits into from
Dec 10, 2019

Conversation

ukclivecox
Copy link
Contributor

Fixes #1233

  • Also fixes typo in go doc notebook

@seldondev
Copy link
Collaborator

Tue Dec 10 15:20:53 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1237/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1237 --build=1

@seldondev
Copy link
Collaborator

Tue Dec 10 15:20:56 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1237/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1237 --build=2

@seldondev
Copy link
Collaborator

Tue Dec 10 16:29:22 UTC 2019
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1237/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1237 --build=3

@seldondev
Copy link
Collaborator

Tue Dec 10 16:29:33 UTC 2019
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1237/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1237 --build=4

@ryandawsonuk
Copy link
Contributor

/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit dfe2f6f into SeldonIO:master Dec 10, 2019
@ukclivecox ukclivecox deleted the 1233_webhook_selectors branch February 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook Selectors only available in k8s >= 1.15
3 participants