Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ambassador weights and HPA deletion #1272

Merged
merged 4 commits into from
Dec 14, 2019
Merged

Fix Ambassador weights and HPA deletion #1272

merged 4 commits into from
Dec 14, 2019

Conversation

ukclivecox
Copy link
Contributor

Fixes #1263
Fixes #1271

@ukclivecox
Copy link
Contributor Author

/ok-to-test

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Dec 14 15:15:40 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1272/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1272 --build=1

@seldondev
Copy link
Collaborator

Sat Dec 14 15:15:43 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1272/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1272 --build=2

@seldondev
Copy link
Collaborator

Sat Dec 14 15:15:52 UTC 2019
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1272/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1272 --build=3

@seldondev
Copy link
Collaborator

Sat Dec 14 15:15:58 UTC 2019
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1272/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1272 --build=4

@seldondev
Copy link
Collaborator

Sat Dec 14 15:16:29 UTC 2019
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1272/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1272 --build=5

@ukclivecox
Copy link
Contributor Author

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 909c780 into SeldonIO:master Dec 14, 2019
@ukclivecox ukclivecox deleted the 1263_hpa_delete branch February 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambassador 404s on Canary Test Delete hpaSepc in seldon deployment doesn't delete the hpa object
2 participants