Fix webhook rbac and add istio tests #1276

ukclivecox · 2019-12-16T06:39:47Z

Fixes #1273
Fixes #1274
Fixes #1275
Fixes #1281

Updates webhook to add selectors for all versions not just 1.0
Add helm templates for certificates in webhook for all versions
Add istio to tests and makes all rolling update tests do both

seldondev · 2019-12-16T06:41:05Z

Mon Dec 16 06:41:04 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=2

seldondev · 2019-12-16T06:41:08Z

Mon Dec 16 06:41:06 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=1

seldondev · 2019-12-16T06:46:52Z

Mon Dec 16 06:46:51 UTC 2019
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=4

seldondev · 2019-12-16T06:47:02Z

Mon Dec 16 06:47:01 UTC 2019
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=3

ukclivecox · 2019-12-16T07:13:35Z

/test integration

seldondev · 2019-12-16T07:14:33Z

Mon Dec 16 07:14:32 UTC 2019
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=5

seldondev · 2019-12-16T07:14:48Z

Mon Dec 16 07:14:47 UTC 2019
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=6

seldondev · 2019-12-16T07:14:53Z

Mon Dec 16 07:14:52 UTC 2019
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=7

axsaucedo · 2019-12-16T10:08:59Z

/test integration

seldondev · 2019-12-16T10:10:19Z

Mon Dec 16 10:10:18 UTC 2019
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=8

adriangonz

Looks good!

seldondev · 2019-12-16T11:34:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2019-12-16T12:12:26Z

New changes are detected. LGTM label has been removed.

seldondev · 2019-12-16T12:13:32Z

Mon Dec 16 12:13:31 UTC 2019
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=9

seldondev · 2019-12-16T12:13:53Z

Mon Dec 16 12:13:52 UTC 2019
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=10

seldondev · 2019-12-16T12:15:10Z

Mon Dec 16 12:15:08 UTC 2019
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=11

seldondev · 2019-12-16T12:15:14Z

Mon Dec 16 12:15:13 UTC 2019
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=12

ukclivecox · 2019-12-16T12:15:46Z

/test integration

seldondev · 2019-12-16T12:17:13Z

Mon Dec 16 12:17:12 UTC 2019
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=13

ukclivecox · 2019-12-16T13:31:13Z

/test integration

seldondev · 2019-12-16T13:32:17Z

Mon Dec 16 13:32:15 UTC 2019
The logs for [integration] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=14

ukclivecox · 2019-12-16T13:49:20Z

/test integration

seldondev · 2019-12-16T13:50:23Z

Mon Dec 16 13:50:22 UTC 2019
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=15

seldondev · 2019-12-16T13:50:31Z

Mon Dec 16 13:50:28 UTC 2019
The logs for [lint] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=16

seldondev · 2019-12-16T13:50:42Z

Mon Dec 16 13:50:41 UTC 2019
The logs for [integration] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=17

ukclivecox · 2019-12-16T14:29:16Z

/test integration

seldondev · 2019-12-16T14:30:25Z

Mon Dec 16 14:30:23 UTC 2019
The logs for [pr-build] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=18

seldondev · 2019-12-16T14:30:36Z

Mon Dec 16 14:30:35 UTC 2019
The logs for [lint] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=19

seldondev · 2019-12-16T14:32:06Z

Mon Dec 16 14:32:05 UTC 2019
The logs for [integration] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=20

ukclivecox · 2019-12-16T15:17:41Z

/test integration

seldondev · 2019-12-16T15:18:53Z

Mon Dec 16 15:18:52 UTC 2019
The logs for [lint] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=22

seldondev · 2019-12-16T15:18:54Z

Mon Dec 16 15:18:53 UTC 2019
The logs for [pr-build] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=21

seldondev · 2019-12-16T15:19:11Z

Mon Dec 16 15:19:10 UTC 2019
The logs for [integration] [23] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/23.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=23

ukclivecox · 2019-12-16T16:01:13Z

/test integration

seldondev · 2019-12-16T16:02:19Z

Mon Dec 16 16:02:18 UTC 2019
The logs for [pr-build] [24] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/24.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=24

seldondev · 2019-12-16T16:02:24Z

Mon Dec 16 16:02:23 UTC 2019
The logs for [lint] [25] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/25.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=25

seldondev · 2019-12-16T16:02:42Z

Mon Dec 16 16:02:41 UTC 2019
The logs for [integration] [26] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1276/26.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1276 --build=26

Fix webhook rbac and add istio tests

3ddbaf0

seldondev added the size/XXL label Dec 16, 2019

Add kustomize cert example update for certs

103382c

lint

6fab67c

ukclivecox requested review from axsaucedo and adriangonz December 16, 2019 10:04

adriangonz approved these changes Dec 16, 2019

View reviewed changes

seldondev assigned adriangonz Dec 16, 2019

seldondev added the lgtm label Dec 16, 2019

seldondev added the approved label Dec 16, 2019

ukclivecox added 3 commits December 16, 2019 12:11

add local operator tests

018ac7f

Merge branch 'master' into istio_tests

87cd1b5

Merge branch '1281_namespace_operator_tests' into istio_tests

e1e87ed

seldondev removed the lgtm label Dec 16, 2019

fix lint

d221d6c

fix istio install

1289ec0

add namespace suffix to namespace for tests

74b7b81

Fix logging error

60f4e9e

lint

a4908d7

seldondev merged commit b01dc1c into SeldonIO:master Dec 16, 2019

axsaucedo unassigned adriangonz May 13, 2021

Fix webhook rbac and add istio tests #1276

Fix webhook rbac and add istio tests #1276

Conversation

ukclivecox commented Dec 16, 2019 • edited Loading

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

axsaucedo commented Dec 16, 2019

seldondev commented Dec 16, 2019

adriangonz left a comment

Choose a reason for hiding this comment

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

seldondev commented Dec 16, 2019

ukclivecox commented Dec 16, 2019 •

edited

Loading