-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure error status codes are surfaced from client failures #1575
Ensure error status codes are surfaced from client failures #1575
Conversation
Mon Mar 23 07:48:19 UTC 2020 impatient try |
Mon Mar 23 07:48:25 UTC 2020 impatient try |
/test integration |
Tue Mar 24 14:53:45 UTC 2020 impatient try |
Tue Mar 24 14:53:48 UTC 2020 impatient try |
Tue Mar 24 14:53:58 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Are there any docs that we need to update to reflect the change on the status code?
Tue Mar 24 17:12:49 UTC 2020 impatient try |
Tue Mar 24 17:12:50 UTC 2020 impatient try |
Tue Mar 24 17:34:15 UTC 2020 impatient try |
Tue Mar 24 17:34:24 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1574