Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure error status codes are surfaced from client failures #1575

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Ensure error status codes are surfaced from client failures #1575

merged 4 commits into from
Mar 25, 2020

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Mar 23, 2020

Fixes #1574

  • Add custom golang error to pass status code back to top level
  • Adds status code and content type as passed back by client
  • Fixes python test for non 200 use case
  • Cleans up test server struct

@seldondev
Copy link
Collaborator

Mon Mar 23 07:48:19 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=2

@seldondev
Copy link
Collaborator

Mon Mar 23 07:48:25 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=1

@ukclivecox ukclivecox changed the title WIP: Ensure error status codes are surfaced from client failures Ensure error status codes are surfaced from client failures Mar 24, 2020
@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Mar 24 14:53:45 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=3

@seldondev
Copy link
Collaborator

Tue Mar 24 14:53:48 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=4

@seldondev
Copy link
Collaborator

Tue Mar 24 14:53:58 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=5

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there any docs that we need to update to reflect the change on the status code?

executor/api/grpc/seldon/server_test.go Outdated Show resolved Hide resolved
@seldondev
Copy link
Collaborator

Tue Mar 24 17:12:49 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=6

@seldondev
Copy link
Collaborator

Tue Mar 24 17:12:50 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=7

@seldondev seldondev added size/L and removed size/M labels Mar 24, 2020
@seldondev
Copy link
Collaborator

Tue Mar 24 17:34:15 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=8

@seldondev
Copy link
Collaborator

Tue Mar 24 17:34:24 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1575/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1575 --build=9

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit ee1874c into SeldonIO:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing status code back from executor service orchestrator
3 participants