Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inclusion of metrics in SeldonMessage configurable in 1.1 #1625

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Make inclusion of metrics in SeldonMessage configurable in 1.1 #1625

merged 1 commit into from
Mar 30, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

Reopening #1590 that closes #1582

@seldondev
Copy link
Collaborator

Fri Mar 27 16:43:50 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=2

@seldondev
Copy link
Collaborator

Fri Mar 27 16:43:52 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=1

@RafalSkolasinski RafalSkolasinski changed the title Issue/1582 Make inclusion of metrics in SeldonMessage configurable in 1.1 Mar 27, 2020
@RafalSkolasinski
Copy link
Contributor Author

Waiting for fix to integration tests being merged in #1623 before running integration tests on this one.

@RafalSkolasinski
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Fri Mar 27 17:05:36 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=3

@seldondev
Copy link
Collaborator

Fri Mar 27 17:29:24 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=4

@seldondev
Copy link
Collaborator

Fri Mar 27 17:30:04 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=5

…le in 1.1" (#1624)"

This reverts commit 1c2b511 and effectively restores original PR.
@seldondev
Copy link
Collaborator

Sat Mar 28 17:04:02 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=6

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Mar 28 17:05:23 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=7

@seldondev
Copy link
Collaborator

Sat Mar 28 17:05:42 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=8

@RafalSkolasinski
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Sat Mar 28 21:09:12 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=9

@RafalSkolasinski
Copy link
Contributor Author

Failure on

[gw3] FAILED test_rolling_updates.py::test_rolling_deployment[graph1.json-graph5.json-True-ambas] 

\retest

@RafalSkolasinski
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Sat Mar 28 21:42:33 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=10

@RafalSkolasinski
Copy link
Contributor Author

Integration tests passed! Let's merge this! :)

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Mar 30 11:16:44 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=11

@seldondev
Copy link
Collaborator

Mon Mar 30 11:16:46 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1625/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1625 --build=12

@seldondev seldondev merged commit 6818fb3 into SeldonIO:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make inclusion of metrics in SeldonMessage configurable in 1.1
3 participants