Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make graph a value rather than point in CRD types #1752

Merged
merged 4 commits into from
May 18, 2020
Merged

Make graph a value rather than point in CRD types #1752

merged 4 commits into from
May 18, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1742

  • Changes the graph to value as it is required.
  • Adds unit test and e2e test

@seldondev
Copy link
Collaborator

Mon Apr 27 11:52:58 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=1

@seldondev
Copy link
Collaborator

Mon Apr 27 11:52:59 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=2

@seldondev
Copy link
Collaborator

Mon Apr 27 11:55:23 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=4

@seldondev
Copy link
Collaborator

Mon Apr 27 11:55:29 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=3

@ukclivecox ukclivecox changed the title Make graph a vaue rather than point in CRD types Make graph a value rather than point in CRD types Apr 30, 2020
@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu May 7 10:14:55 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=6

@seldondev
Copy link
Collaborator

Thu May 7 10:14:56 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=5

@seldondev
Copy link
Collaborator

Mon May 18 09:13:07 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=7

@seldondev
Copy link
Collaborator

Mon May 18 09:13:17 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=8

@seldondev
Copy link
Collaborator

Mon May 18 09:42:49 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=9

@seldondev
Copy link
Collaborator

Mon May 18 09:42:57 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1752/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1752 --build=10

@seldondev seldondev merged commit dc6e7ea into SeldonIO:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed calling webhook
3 participants