-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating podinfo volume name to be seldon specific #1863
Conversation
Thu May 21 11:39:39 UTC 2020 impatient try |
Thu May 21 11:39:39 UTC 2020 impatient try |
/test integration |
Thu May 21 13:07:06 UTC 2020 impatient try |
@cliveseldon @adriangonz Was wondering if we should change the volume mount path from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold |
@SachinVarghese I think the path is fine. Istio does use an istio-specific mount path but I don't think it's necessary. The mount path is only at the container level so there shouldn't be a clash there. The clash on the volume name is because that's at pod level. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ryandawsonuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue May 26 10:10:25 UTC 2020 impatient try |
/test this |
Wed May 27 10:35:52 UTC 2020 impatient try |
Wed May 27 10:50:57 UTC 2020 impatient try |
Wed May 27 10:51:41 UTC 2020 impatient try |
failed to trigger Pull Request pipeline
|
Related to istio/istio#22246