Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating podinfo volume name to be seldon specific #1863

Merged
merged 1 commit into from
May 27, 2020

Conversation

SachinVarghese
Copy link
Contributor

Related to istio/istio#22246

@seldondev
Copy link
Collaborator

Thu May 21 11:39:39 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1863/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1863 --build=1

@seldondev
Copy link
Collaborator

Thu May 21 11:39:39 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1863/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1863 --build=2

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu May 21 13:07:06 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1863/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1863 --build=3

@SachinVarghese
Copy link
Contributor Author

@cliveseldon @adriangonz Was wondering if we should change the volume mount path from /etc/podinfo to /etc/seldon/podinfo (similar to Istio) to avoid clashes as a part of this PR? Do you foresee any issues with that?

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ryandawsonuk
Copy link
Contributor

/hold

@ryandawsonuk
Copy link
Contributor

@SachinVarghese I think the path is fine. Istio does use an istio-specific mount path but I don't think it's necessary. The mount path is only at the container level so there shouldn't be a clash there. The clash on the volume name is because that's at pod level.

@ryandawsonuk
Copy link
Contributor

/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue May 26 10:10:25 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1863/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1863 --build=5

@adriangonz
Copy link
Contributor

/test this

@seldondev
Copy link
Collaborator

Wed May 27 10:35:52 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1863/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1863 --build=6

@seldondev
Copy link
Collaborator

Wed May 27 10:50:57 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1863/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1863 --build=8

@seldondev
Copy link
Collaborator

Wed May 27 10:51:41 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1863/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1863 --build=9

@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref c0c7738
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha c0c7738
  • failed to process repo SeldonIO/seldon-core refref c0c7738
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants