-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and document charts #1906
Conversation
/cc @axsaucedo @ryandawsonuk @cliveseldon |
Mon Jun 1 14:09:57 UTC 2020 impatient try |
Mon Jun 1 14:10:18 UTC 2020 impatient try |
@adriangonz this is great! We actually already have the helm chart for seldon-core-operator semi-documented in https://docs.seldon.io/projects/seldon-core/en/latest/reference/helm.html Would this work with the seldon-core-operator chart as well? It would be great to add the README.md page in there instead of the reference of the YAML! Looks good from my side, happy to approve based on whether we'd want to do the above on a separate PR |
@axsaucedo I'm happy to add it on this PR. I also noticed that I haven't tried yet how we can expose the generated docs in the docs at docs.seldon.io. What's done it's still useful to assess if we like this direction or not. I'm gonna turn this one into a WIP, and I'll add:
|
@adriangonz I think it woudl just be a matter of generating the readme.md, and then just linking that directly from one of the doc pages - I believe all the linked readme documents are packaged together in the live docs. You can try building the docs locally (using the makefile in the docs folder) |
Thu Jun 4 12:52:42 UTC 2020 impatient try |
Thu Jun 4 12:52:42 UTC 2020 impatient try |
Thu Jun 4 12:54:10 UTC 2020 impatient try |
Thu Jun 4 12:54:34 UTC 2020 impatient try |
Thu Jun 4 13:52:08 UTC 2020 impatient try |
Thu Jun 4 13:52:11 UTC 2020 impatient try |
@axsaucedo @cliveseldon @ryandawsonuk this should be ready for review now. Looking forward to hearing your thoughts! 👍 |
Thu Jun 4 14:47:32 UTC 2020 impatient try |
Thu Jun 4 14:47:35 UTC 2020 impatient try |
Fri Jun 5 09:41:07 UTC 2020 impatient try |
Fri Jun 5 09:41:12 UTC 2020 impatient try |
Looks good! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is a first stab at #1879 . It explores how we can leverage
helm-docs
to generate the documentation of our Helm charts. This tool,helm-docs
, will parse the chart'svalues.yaml
, extracting the different options that we can configure, as well as:From these, it generates a
README.md
with a table documenting all the chart's values. To showcase how this works, this PR just generates thisREADME.md
for a couple charts:seldon-single-model
seldon-openvino
Changelog
seldon-single-model
andseldon-openvino
seldon-single-model
and update part of its structureseldon-openvino
as deprecatedseldon-single-model
.helmdocsignore
to ignore every other chartdocs
target inhelm-charts/Makefile
TODO
seldon-core-operator
's chart