Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analytics option to switch nodeExporter port #1917

Merged

Conversation

ryandawsonuk
Copy link
Contributor

@ryandawsonuk ryandawsonuk commented Jun 5, 2020

fixes #1916

First time I ran the upgrade I hit the immutable field problem helm/helm#7173

Then I had to do:

kubectl delete deployment -n seldon-system -l app=grafana

If I'd done that once before upgrading that probably would've been enough. But because of the failed attempt I also had to do:

kubectl delete -n seldon-system sa seldon-core-analytics-kube-state-metrics
kubectl delete clusterrole seldon-core-analytics-kube-state-metrics
kubectl delete clusterrolebinding seldon-core-analytics-kube-state-metrics
kubectl delete -n seldon-system svc seldon-core-analytics-kube-state-metrics
kubectl delete deployment -n seldon-system seldon-core-analytics-kube-state-metrics

Then I was able to run

helm upgrade --install seldon-core-analytics ./helm-charts/seldon-core-analytics/ --namespace seldon-system --set prometheus.nodeExporter.service.hostPort=9200 --set prometheus.nodeExporter.service.servicePort=9200

Have included a note on upgrading in the upgrading.md

@seldondev
Copy link
Collaborator

Fri Jun 5 10:26:48 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=1

@seldondev
Copy link
Collaborator

Fri Jun 5 10:27:54 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=2

@seldondev
Copy link
Collaborator

Fri Jun 5 10:28:59 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=4

@seldondev
Copy link
Collaborator

Fri Jun 5 10:29:15 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=3

@ryandawsonuk
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Fri Jun 5 10:43:32 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=5

@axsaucedo axsaucedo requested review from axsaucedo and removed request for gsunner and gipster June 12, 2020 15:03
@axsaucedo
Copy link
Contributor

Looks good
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jun 12 15:06:33 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=6

@seldondev
Copy link
Collaborator

Fri Jun 12 15:06:37 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=7

@axsaucedo
Copy link
Contributor

Not sure how this could break PR build 🤔
/test this

@seldondev
Copy link
Collaborator

Fri Jun 12 15:14:44 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1917/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1917 --build=8

@seldondev seldondev merged commit d8cbc2e into SeldonIO:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't change analytics nodeExporter port
3 participants