-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ambassador ingress instructions to include edgectl install #2007
Update Ambassador ingress instructions to include edgectl install #2007
Conversation
Hi @oparryevans. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
doc/source/ingress/ambassador.md
Outdated
@@ -2,28 +2,34 @@ | |||
|
|||
Seldon Core works well with [Ambassador](https://www.getambassador.io/), allowing a single ingress to be used to expose ambassador and [running machine learning deployments can then be dynamically exposed](https://kubernetes.io/blog/2018/06/07/dynamic-ingress-in-kubernetes/) through seldon-created ambassador configurations. In this doc we will discuss how your Seldon Deployments are exposed via Ambassador and how you can use both to do various production rollout strategies. | |||
|
|||
## Installing Ambassador Edge Stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to add a section on the Pure OSS stack install of Ambassador and not in the edge stack that this is not open source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cliveseldon - I've included instructions for installing the OSS Ambassador API Gateway in the latest commit, hopefully the new changes answer your question.
/approve |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thu Jul 2 10:45:42 UTC 2020 impatient try |
Thu Jul 2 10:45:41 UTC 2020 impatient try |
Thu Jul 2 11:20:07 UTC 2020 impatient try |
Thu Jul 2 11:20:21 UTC 2020 impatient try |
Changelog: