Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ambassador ingress instructions to include edgectl install #2007

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

oparryevans
Copy link
Contributor

Changelog:

  • Include instructions in the documentation for installing ambassador using edgectl as this will simplify the installation process by automatically setting up a load balancer, TLS, HTTPS, and a domain name.
  • Update the Ambassador REST instructions and curl example to include the hostname provisioned by Ambassador when using the edgectl install.

@seldondev
Copy link
Collaborator

Hi @oparryevans. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -2,28 +2,34 @@

Seldon Core works well with [Ambassador](https://www.getambassador.io/), allowing a single ingress to be used to expose ambassador and [running machine learning deployments can then be dynamically exposed](https://kubernetes.io/blog/2018/06/07/dynamic-ingress-in-kubernetes/) through seldon-created ambassador configurations. In this doc we will discuss how your Seldon Deployments are exposed via Ambassador and how you can use both to do various production rollout strategies.

## Installing Ambassador Edge Stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add a section on the Pure OSS stack install of Ambassador and not in the edge stack that this is not open source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cliveseldon - I've included instructions for installing the OSS Ambassador API Gateway in the latest commit, hopefully the new changes answer your question.

@ukclivecox
Copy link
Contributor

/approve

@ukclivecox
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Jul 2 10:45:42 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2007/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2007 --build=2

@seldondev
Copy link
Collaborator

Thu Jul 2 10:45:41 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2007/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2007 --build=1

@seldondev
Copy link
Collaborator

Thu Jul 2 11:20:07 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2007/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2007 --build=4

@seldondev
Copy link
Collaborator

Thu Jul 2 11:20:21 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2007/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2007 --build=3

@seldondev seldondev merged commit 004a49d into SeldonIO:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants