-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example and script to patch the bug when upgrading 1.1 to 1.2 #2021
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Sat Jun 27 10:19:31 UTC 2020 impatient try |
Sat Jun 27 10:19:32 UTC 2020 impatient try |
doc/source/examples/patch_1_2.nblink
Outdated
@@ -0,0 +1,3 @@ | |||
{ | |||
"path": "../../../examples/models/sklearn_iris/sklearn_iris.ipynb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this file named patch but points to sklearn_iris. Same for above but other way round?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch it seems I ended up editing the wrong file, I've updated it now
Sat Jun 27 14:33:32 UTC 2020 impatient try |
Sat Jun 27 14:33:37 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Jul 6 11:39:18 UTC 2020 impatient try |
Inlcudes notebook to show how to fix patch