Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example and script to patch the bug when upgrading 1.1 to 1.2 #2021

Merged
merged 3 commits into from
Jun 27, 2020

Conversation

axsaucedo
Copy link
Contributor

Inlcudes notebook to show how to fix patch

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@axsaucedo axsaucedo changed the title Provides a patch for the bug when upgrading 1.1 to 1.2 Example and script to patch the bug when upgrading 1.1 to 1.2 Jun 27, 2020
@seldondev
Copy link
Collaborator

Sat Jun 27 10:19:31 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2021/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2021 --build=2

@seldondev
Copy link
Collaborator

Sat Jun 27 10:19:32 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2021/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2021 --build=3

@@ -0,0 +1,3 @@
{
"path": "../../../examples/models/sklearn_iris/sklearn_iris.ipynb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file named patch but points to sklearn_iris. Same for above but other way round?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch it seems I ended up editing the wrong file, I've updated it now

@seldondev
Copy link
Collaborator

Sat Jun 27 14:33:32 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2021/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2021 --build=4

@seldondev
Copy link
Collaborator

Sat Jun 27 14:33:37 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2021/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2021 --build=5

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 093e512 into SeldonIO:master Jun 27, 2020
@seldondev
Copy link
Collaborator

Mon Jul 6 11:39:18 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2021/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2021 --build=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants