Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade k8s.io and jaeger-client-go libraries #2169

Merged
merged 1 commit into from
Jul 21, 2020
Merged

upgrade k8s.io and jaeger-client-go libraries #2169

merged 1 commit into from
Jul 21, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 20, 2020

What this PR does / why we need it:

To stay up to date

Which issue(s) this PR fixes:

Closes #2088

Special notes for your reviewer:

  • Bumped k8s.io to v0.17.9
  • Bumped github.com/uber/jaeger-client-go to v2.25

Does this PR introduce a user-facing change?:

NONE

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

STARTING TEST [ pr-build # 1 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/1.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2169 --build=1

@seldondev
Copy link
Collaborator

STARTING TEST [ lint # 2 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/2.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2169 --build=2

@seldondev
Copy link
Collaborator

STARTING TEST [ notebooks # 3 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/3.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2169 --build=3

@seldondev
Copy link
Collaborator

STARTING TEST [ integration # 4 ]

Logs will be available when test completes in the following link:
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/4.log

Impatient try:
jx get build logs SeldonIO/seldon-core/PR-2169 --build=4

@seldondev
Copy link
Collaborator

SUCCESS [lint # 2] TEST PASSED ✅

Well done! 😎

@seldondev
Copy link
Collaborator

SUCCESS [pr-build # 1] TEST PASSED ✅

Well done! 😎

@seldondev
Copy link
Collaborator

SUCCESS [notebooks # 3] TEST PASSED ✅

Well done! 😎

@seldondev
Copy link
Collaborator

SUCCESS [integration # 4] TEST PASSED ✅

Well done! 😎

@RafalSkolasinski
Copy link
Contributor Author

Tests rock solid, on the first try 🚀

@RafalSkolasinski
Copy link
Contributor Author

Rebased onto master. Triggering tests to verify if we have flakiness or not (tests passed before).

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

Tue Jul 21 12:51:28 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2169 --build=5

@seldondev
Copy link
Collaborator

Tue Jul 21 12:51:33 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2169 --build=6

@seldondev
Copy link
Collaborator

Tue Jul 21 12:51:41 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2169 --build=8

@seldondev
Copy link
Collaborator

Tue Jul 21 12:51:47 UTC 2020
The logs for [notebooks] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2169/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2169 --build=7

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 405c8d0 into SeldonIO:master Jul 21, 2020
@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint d93e079 link /test lint
pr-build d93e079 link /test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies of Operator and Executor
3 participants