-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s libs to 1.18.6 #2385
Conversation
Sun Sep 6 18:35:40 UTC 2020 impatient try |
Sun Sep 6 18:35:44 UTC 2020 impatient try |
/test integration |
Sun Sep 6 19:09:53 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
@axsaucedo do you know maybe why this got stuck in the merge pool? |
@RafalSkolasinski it seems lint is still running |
Wed Sep 9 12:15:36 UTC 2020 impatient try |
@RafalSkolasinski @cliveseldon it seems lint is failing due to licenses - rebase should fix it |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Sep 14 16:05:19 UTC 2020 impatient try |
Mon Sep 14 16:05:36 UTC 2020 impatient try |
Mon Sep 14 16:41:10 UTC 2020 impatient try |
Mon Sep 14 16:41:13 UTC 2020 impatient try |
/test lint |
Mon Sep 14 21:06:33 UTC 2020 impatient try |
/test lint |
Tue Sep 15 06:33:44 UTC 2020 impatient try |
Tue Sep 15 06:57:25 UTC 2020 impatient try |
Tue Sep 15 06:57:34 UTC 2020 impatient try |
/test this |
/test lint |
Thu Sep 17 07:18:46 UTC 2020 impatient try |
Thu Sep 17 07:19:43 UTC 2020 impatient try |
/test integration |
Thu Sep 17 07:33:17 UTC 2020 impatient try |
/test all |
Oh wasn't aiming to run the |
Thu Sep 17 18:14:08 UTC 2020 impatient try |
Thu Sep 17 18:14:19 UTC 2020 impatient try |
Thu Sep 17 18:14:20 UTC 2020 impatient try |
Thu Sep 17 18:14:28 UTC 2020 impatient try |
Fri Sep 18 08:02:10 UTC 2020 impatient try |
Fri Sep 18 08:02:21 UTC 2020 impatient try |
Fri Sep 18 08:20:56 UTC 2020 impatient try |
Fri Sep 18 08:20:56 UTC 2020 impatient try |
…ore into 2360_1.18_libraries
Fri Sep 18 08:31:51 UTC 2020 impatient try |
Fri Sep 18 08:31:52 UTC 2020 impatient try |
@cliveseldon: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Mon Sep 21 08:18:54 UTC 2020 impatient try |
Mon Sep 21 08:18:55 UTC 2020 impatient try |
Mon Sep 21 09:14:15 UTC 2020 impatient try |
Mon Sep 21 09:14:21 UTC 2020 impatient try |
What this PR does / why we need it:
Update ks8 libs to 1.18 latest
Which issue(s) this PR fixes:
Fixes #1949
Fixes #2360
Special notes for your reviewer:
Does this PR introduce a user-facing change?: