Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image Jenkinx X build failures #2449

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

axsaucedo
Copy link
Contributor

Fixes #2443

The jenkins X uses the VERSION branch as the base branch, so when it was changed to used nighly-<version> it broke the image build, resulting in the wrong branch being built. Now this builds on the correct branch back to v<version>

@seldondev
Copy link
Collaborator

Thu Sep 17 12:58:01 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2449/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2449 --build=2

@seldondev
Copy link
Collaborator

Thu Sep 17 12:58:01 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2449/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2449 --build=1

@RafalSkolasinski
Copy link
Contributor

Should also fix #2444

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

let's merge it and see if all problems go away!

@RafalSkolasinski
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Sep 17 13:21:03 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2449/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2449 --build=3

@seldondev
Copy link
Collaborator

Thu Sep 17 13:21:08 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2449/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2449 --build=4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI builds sklearn server with wrong sklearn version -> TestNotebooks.test_explainer_examples fails
3 participants