-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image Jenkinx X build failures #2449
Conversation
Thu Sep 17 12:58:01 UTC 2020 impatient try |
Thu Sep 17 12:58:01 UTC 2020 impatient try |
Should also fix #2444 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
let's merge it and see if all problems go away!
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thu Sep 17 13:21:03 UTC 2020 impatient try |
Thu Sep 17 13:21:08 UTC 2020 impatient try |
Fixes #2443
The jenkins X uses the VERSION branch as the base branch, so when it was changed to used
nighly-<version>
it broke the image build, resulting in the wrong branch being built. Now this builds on the correct branch back tov<version>