Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image version bug to not overwrite non seldon images #2513

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix image version bug to not overwrite non seldon images #2513

merged 1 commit into from
Oct 15, 2020

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Oct 1, 2020

What this PR does / why we need it:

The release.py script changes all prepacked server image versions including new Triton image version. It should only change seldon images versions.

TRITON_SERVER:
grpc:
defaultImageVersion: "1.3.0"
image: nvcr.io/nvidia/tritonserver
rest:
defaultImageVersion: "1.3.0"
image: nvcr.io/nvidia/tritonserver

Which issue(s) this PR fixes:

Fixes #2511

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Thu Oct 1 17:48:17 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2513/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2513 --build=2

@seldondev
Copy link
Collaborator

Thu Oct 1 17:49:43 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2513/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2513 --build=1

@axsaucedo
Copy link
Contributor

It seems that get_current_version assumes that the version.txt holds the previous version which would be aligned to the one from the images, but normally the version.txt file holds the "next" version, and then the script uses it to then replace all the components.

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Oct 15 12:35:42 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2513/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2513 --build=3

@seldondev
Copy link
Collaborator

Thu Oct 15 12:35:45 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2513/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2513 --build=4

@seldondev seldondev merged commit 251f80a into SeldonIO:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triton Server Image Incorrect
3 participants